Review Request 120353: Add timezones i18n stuff

[Sebastian Kügler]

> On Sept. 24, 2014, 12:42 p.m., Sebastian Kügler wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 418
> > <https://git.reviewboard.kde.org/r/120353/diff/1/?file=315266#file315266line418>
> >
> >     Does it really make sense to have translations added for UTC offsets, and UTC itself?
> 
> Martin Klapetek wrote:
>     I thought for some localizations it could be useful...like we put i18n around names in KAboutData.
> 
> Sebastian Kügler wrote:
>     Which ones do you have in mind? I don't know of any translation for UTC, but I'm not that well-informed.
> 
> Lukáš Tinkl wrote:
>     I would leave this as-is, although RTL langs might want to translate it somehow :)
> 
> Martin Klapetek wrote:
>     Mostly the part after UTC, which should be localized.
> 
> Chusslove Illich wrote:
>     The rule is really simple: every piece of text that users may see must be exposed to translators. No exceptions, nothing further to think about.

Okay, thanks! :) (dropping this issue)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120353/#review67347
-----------------------------------------------------------


On Sept. 24, 2014, 12:02 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120353/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 12:02 p.m.)
> 
> 
> Review request for Localization and Translation (l10n) and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> So in Plasma 5 we're adding support for timezones into the clock applet. It's based on QTimeZone and that uses IDs which are consisting of "Continent/City". Qt has no accessor methods for getting the city of the given timezone so we're parsing the timezone ID and using the part after "/" as the city and we display that in the UI.
> 
> We want those cities translated however so it can display eg. "Praha" instead of "Prague" for Czech users. So I've created this helper class which has a dictionary of timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure where exactly to put it, I'd prefer KI18n framework but as we would like to have this in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does not (and probably will not) depend on KI18n 5.3.
> 
> I'm adding the l10n group to the reviewers - guys can you please comment/+1 this?
> 
> If this is deemed good enough, I'd like to also add the country and continent i18n functions into that class afterwards.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   applets/digital-clock/plugin/timezonesi18n.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonesi18n.cpp PRE-CREATION 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120353/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140924/d14a7e0b/attachment.html>