Review Request 120353: Add timezones i18n stuff

[Martin Klapetek]

> On Sept. 24, 2014, 4:55 p.m., Lukáš Tinkl wrote:
> > This should either be fixed in QTimezone or we can just use KLocale/KTimezone to get the stuff we need meanwhile, no need to reinvent the wheel. Users don't care

KTimezone does not implement the city either as far as I can see, no reinventing there. Plus, the whole backend for the clock is using QTimeZone and KTimeZone does not work with that, it would mean rewriting the whole stack to KTimeZone or rewriting KTimeZone to support QTimeZone. Finally, given that there are only "returns things in its own language"-kindof-things in Qt (like eg. QLocale.countryToName() which returns "Deutschland" for "Germany", but would never return "Německo"), I wouldn't bet on this actually getting into Qt.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120353/#review67364
-----------------------------------------------------------


On Sept. 24, 2014, 2:02 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120353/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 2:02 p.m.)
> 
> 
> Review request for Localization and Translation (l10n) and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> So in Plasma 5 we're adding support for timezones into the clock applet. It's based on QTimeZone and that uses IDs which are consisting of "Continent/City". Qt has no accessor methods for getting the city of the given timezone so we're parsing the timezone ID and using the part after "/" as the city and we display that in the UI.
> 
> We want those cities translated however so it can display eg. "Praha" instead of "Prague" for Czech users. So I've created this helper class which has a dictionary of timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure where exactly to put it, I'd prefer KI18n framework but as we would like to have this in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does not (and probably will not) depend on KI18n 5.3.
> 
> I'm adding the l10n group to the reviewers - guys can you please comment/+1 this?
> 
> If this is deemed good enough, I'd like to also add the country and continent i18n functions into that class afterwards.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   applets/digital-clock/plugin/timezonesi18n.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonesi18n.cpp PRE-CREATION 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120353/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140924/401823ba/attachment-0001.html>