Review Request 120314: Add timezones support into clock applet
Martin Klapetek
martin.klapetek at gmail.com
Wed Sep 24 09:43:42 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/
-----------------------------------------------------------
(Updated Sept. 24, 2014, 11:43 a.m.)
Review request for Plasma.
Changes
-------
Revert the latest changes and simply disable the "Local" checkbox, this makes sure it always stays selected. Makes things simpler.
Repository: plasma-workspace
Description
-------
I've picked up Kai's branch where he started the timezone support and finished it.
New features:
* timezones tab in the config
* changing timezones by scrolling a wheel on the clock
* that's optional, defaults to off
* displaying non-local timezones as either city or abbreviation
* "Show time zone" config option is now changed to "Show local time zone" as foreign zones are always displayed by default
What's still missing:
* selecting default timezone in the config (should be fairly easy; currently the last used is restored on login
* timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way
Diffs (updated)
-----
applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION
applets/digital-clock/package/contents/ui/main.qml e78f1f3
applets/digital-clock/plugin/CMakeLists.txt 0590e6e
applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION
applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION
applets/digital-clock/plugin/processrunnerplugin.h 2b6317b
applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3
applets/digital-clock/plugin/qmldir 3d57bbb
applets/digital-clock/plugin/timezonedata.h PRE-CREATION
applets/digital-clock/plugin/timezonemodel.h PRE-CREATION
applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION
dataengines/time/timesource.cpp b79fd7c
applets/digital-clock/package/contents/config/config.qml f897c9a
applets/digital-clock/package/contents/config/main.xml cbeb02f
applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172
applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878
Diff: https://git.reviewboard.kde.org/r/120314/diff/
Testing
-------
I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change).
File Attachments
----------------
Timezone & date displayed
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
Timezone without date
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140924/7dff8cee/attachment.html>
More information about the Plasma-devel
mailing list