Review Request 120351: Only show keyboard layout OSD on key pressed

Martin Klapetek martin.klapetek at gmail.com
Wed Sep 24 07:29:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120351/#review67340
-----------------------------------------------------------

Ship it!



kcms/keyboard/keyboard_daemon.cpp
<https://git.reviewboard.kde.org/r/120351/#comment47007>

    This should have stayed in the layoutChanged method


- Martin Klapetek


On Sept. 24, 2014, 9:10 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120351/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 9:10 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Only show keyboard layout OSD on key pressed. For automatic switching or
> plamsa interaction we don't want an OSD each time.
> 
> BUG:339339
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_daemon.cpp c72960b 
> 
> Diff: https://git.reviewboard.kde.org/r/120351/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140924/9501586e/attachment.html>


More information about the Plasma-devel mailing list