Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119081/#review67278
-----------------------------------------------------------


+1 since i like the approach and the change seems OK to me. Someone else should give the final ship it since i don't know the consequences it could have.

- Mark Gaiser


On sep 23, 2014, 8:36 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119081/
> -----------------------------------------------------------
> 
> (Updated sep 23, 2014, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> This is what the core ioslaves such as file or http do. Also dropped
> the kio_ prefix to the library name since it isn't needed now that we
> install them into a kio directory
> 
> 
> Diffs
> -----
> 
>   archive/CMakeLists.txt ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708 
>   archive/ar.protocol 7a848e505e5f00121e8ec5493564dfacdd405c31 
>   archive/tar.protocol 19447a5e75b106e7a8c8e8396375bb1fc600a6da 
>   archive/zip.protocol ce7c54b4e92dfab29150246bf6588d1f8bb49057 
>   bookmarks/CMakeLists.txt 703b109c2e049edecce1742482bd82e5c92caecd 
>   bookmarks/bookmarks.protocol 0642bd2f7277be8707351582f219281d45834fa6 
>   desktop/CMakeLists.txt f7bd6709340a5f4e7e5f6fbd076400a76b526cd8 
>   desktop/desktop.protocol 0e388386f1794dd90d445ec146ef54a04f595c8b 
>   filter/CMakeLists.txt 240cc7b57bd38e86fd50084e53c17f1672b2b946 
>   filter/bzip.protocol 7d3cb570fbc534fbba22dd8e10472b47053c7195 
>   filter/bzip2.protocol 1baaf7dd610f39325b2aa21bdee5bf1e63e5835f 
>   filter/gzip.protocol 8ed55ec16f49f42fe6d419327484b33d59ec537b 
>   filter/lzma.protocol 13bb28e3d870f8130d052efd97a5a688d9133c31 
>   filter/xz.protocol f4fb7f01146cbf4d5afce528462e0c5dafa9591e 
>   fish/CMakeLists.txt 24136d4dac01a8a08db8d17380661a9051fa0b04 
>   fish/fish.protocol ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2 
>   info/CMakeLists.txt 0163e82c4f865e3fb3b09bf5ddd44e272ce9c609 
>   info/info.protocol fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb 
>   man/CMakeLists.txt 3343ed85978dbbfa72a5f2cc8530d0f0c043df48 
>   man/man.protocol cc100ce5ec48b40c890abe5d7afdf02ef589810b 
>   network/ioslave/CMakeLists.txt 67fc482cd390f35fb2d5c1740994d2fe9db254f1 
>   network/ioslave/network.protocol 1e10cc6c3a6aadf2ee6794ab36200ef6793e324e 
>   nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 
>   nfs/nfs.protocol 85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001 
>   recentdocuments/CMakeLists.txt bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f 
>   recentdocuments/recentdocuments.protocol c0bf1ebd80a2c696cad3062ef047ac4847270fc5 
>   settings/CMakeLists.txt 5a57a1840fb33b32701a6ecfff24c42739b05c45 
>   settings/settings.protocol efb03e865594f30be5ed0d1013d31a0200eed816 
>   sftp/CMakeLists.txt defb7dd041ebfd5af0ac19a252cc9f2f454f67f9 
>   sftp/sftp.protocol ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8 
>   smb/CMakeLists.txt a3a772f3028995b811b01fcebe11d8715d3e1620 
>   smb/smb.protocol e58597844ff8554e837f6ee8807d17820e377945 
>   thumbnail/CMakeLists.txt f3733d452eb133d2b5a1445740db0312cd5d8251 
>   thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9 
>   trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c 
>   trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e 
> 
> Diff: https://git.reviewboard.kde.org/r/119081/diff/
> 
> 
> Testing
> -------
> 
> Archive protocol works fine in dolphin (KF5)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140923/84f3cbb8/attachment.html>