Review Request 120329: PlasmaShell and PlasmaSurface interfaces

[Martin Gräßlin]

> On Sept. 23, 2014, 7:51 a.m., Martin Gräßlin wrote:
> > src/client/plasma_surface.h, line 125
> > <https://git.reviewboard.kde.org/r/120329/diff/1/?file=314687#file314687line125>
> >
> >     I'm not sure whether we need this. Plasma is using kscreen and not QScreen.
> 
> Pier Luigi Fiorini wrote:
>     There are other components to be ported that doesn't use KScreen, for instance ksplashqml.
>     Besides without QScreen how can we know the wl_output?
>     Also, using the QScreen or Wayland backends on Plasma should allow us to map KScreen::Output to QScreen (if I recall plasmashell already do that).
> 
> Martin Gräßlin wrote:
>     > There are other components to be ported that doesn't use KScreen, for instance ksplashqml.
>     
>     I don't think ksplashqml will use PlasmaSurface (why should it?). It's a perfect use case for the fullscreen shell protocol.
> 
> Pier Luigi Fiorini wrote:
>     For the surface role, there's no need for the fullscreen shell protocol when a session compositor just need to know its role to map it above any other window.
>     Plus ksplashqml is already using PlasmaSurface on my branch :)

my thought was going in the direction of:
* ksplashqml uses fullscreen shell protocol with "system" compositor
* kwin has time to startup and takes over the fullscreen shell once everything is setup

if ksplashqml connects to KWin, the startup of KWin becomes important while otherwise it would just not matter. We want flicker free startup and using the "system" compositor's fullscreen shell might be the solution to it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120329/#review67255
-----------------------------------------------------------


On Sept. 23, 2014, 7:39 a.m., Pier Luigi Fiorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120329/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 7:39 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> PlasmaShell and PlasmaSurface interfaces
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_registry.cpp 54aa9a560153d00924d4e73c75f029ed1d1ad788 
>   src/client/CMakeLists.txt e00f4573ad22efc9b5776b5ef900854c04f8afd6 
>   src/client/plasma_shell.h PRE-CREATION 
>   src/client/plasma_shell.cpp PRE-CREATION 
>   src/client/plasma_surface.h PRE-CREATION 
>   src/client/plasma_surface.cpp PRE-CREATION 
>   src/client/registry.h 103be0aec9cae6d76c62fd32481eaaafa5a161f0 
>   src/client/registry.cpp 17d738415e395fb638751ac6429d1fc0e3ededd9 
> 
> Diff: https://git.reviewboard.kde.org/r/120329/diff/
> 
> 
> Testing
> -------
> 
> Work in progress Plasma port to Wayland.
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140923/e885c457/attachment.html>