Review Request 120329: PlasmaShell and PlasmaSurface interfaces

[Martin Gräßlin]

> On Sept. 23, 2014, 7:39 a.m., Martin Gräßlin wrote:
> > I am not comfortable with this going into the master branch yet. I do want master to get into the state where we can provide API and ABI stability. By adding development code it would become difficult to reach this state.
> > 
> > What I find most problematic is the requirement of having to use the QPA connection. This means the code is currently unusable as it requires an unreleased Qt component (I don't accept QtWayland dependency neither direct or indirect till it's released and we depend on that Qt version). Also this makes the library difficult to use as some parts can and some parts cannot be used with the ConnectionThread. I would like us to find a solution for this problem before it goes into master branch.
> 
> Pier Luigi Fiorini wrote:
>     qtwayland should be released with Qt 5.4, but if it doesn't and there's no solution but use the QPA connection that means no Plasma on Wayland at all. :(
>     As far as having to use the QPA connection: I don't like it either but you need the native interface to get wl_surface out of a QWindow anyway and using the ConnectionThread connection gives protocol errors as the wl_surface is not recognized.
>     In the Qt 5 world I guess that's the way it is supposed to be: QPA exposes the native interface details.

I think we need to invest some thoughts in that problem ;-) At least for the unit tests it would be very good to be able to get our own wl_surface for a QWindow. I'm quite sure that there is a solution to the problem. It might require changes in the stack, though. Maybe one needs to get Wayland library sharing between connections or something like that.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120329/#review67254
-----------------------------------------------------------


On Sept. 23, 2014, 7:39 a.m., Pier Luigi Fiorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120329/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 7:39 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> PlasmaShell and PlasmaSurface interfaces
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_registry.cpp 54aa9a560153d00924d4e73c75f029ed1d1ad788 
>   src/client/CMakeLists.txt e00f4573ad22efc9b5776b5ef900854c04f8afd6 
>   src/client/plasma_shell.h PRE-CREATION 
>   src/client/plasma_shell.cpp PRE-CREATION 
>   src/client/plasma_surface.h PRE-CREATION 
>   src/client/plasma_surface.cpp PRE-CREATION 
>   src/client/registry.h 103be0aec9cae6d76c62fd32481eaaafa5a161f0 
>   src/client/registry.cpp 17d738415e395fb638751ac6429d1fc0e3ededd9 
> 
> Diff: https://git.reviewboard.kde.org/r/120329/diff/
> 
> 
> Testing
> -------
> 
> Work in progress Plasma port to Wayland.
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140923/e1487a3a/attachment-0001.html>