Review Request 120222: When the button is being pressed draw background like it has focus

Andrew Lake jamboarder at gmail.com
Mon Sep 22 23:33:50 UTC 2014



> On Sept. 22, 2014, 11:06 p.m., David Edmundson wrote:
> > bump.

In case it matters, I have no objection to this change.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120222/#review67247
-----------------------------------------------------------


On Sept. 15, 2014, 6:29 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120222/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 6:29 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> When the button is being pressed draw like it has focus
> 
> PushButtons typically turn blue because they gain focus, whereas tool
> buttons don't. This means buttons look inconsistent.
> 
> Also it fixes QtQuickControls push buttons which do change
> focus when pressed
> 
> BUG: 339099
> 
> 
> Diffs
> -----
> 
>   kstyle/breezestyle.cpp b0a3fc9 
> 
> Diff: https://git.reviewboard.kde.org/r/120222/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140922/870940aa/attachment.html>


More information about the Plasma-devel mailing list