Review Request 120318: PoC: Package Manager integration for the AppsModel

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120318/
-----------------------------------------------------------

(Updated Sept. 22, 2014, 3:34 p.m.)


Review request for Plasma and Eike Hein.


Changes
-------

Separate FindPackageNameJob into a separate class.
Made the dependency optional.


Repository: plasma-desktop


Description
-------

I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future.

It adds an entry on the menu that is called "Remove '<packagename>'" that opens a software center. I set it to muon-discover for now, but this should be iterated over.

To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best.


Diffs (updated)
-----

  CMakeLists.txt 7b794ff 
  applets/kicker/CMakeLists.txt 0688732 
  applets/kicker/plugin/appsmodel.cpp b88d711 
  applets/kicker/plugin/findpackagenamejob.h PRE-CREATION 
  applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION 
  config-workspace.h.cmake 58a11d4 

Diff: https://git.reviewboard.kde.org/r/120318/diff/


Testing
-------

I uninstalled openarena, selfcompiled software cannot removed.

The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140922/882fc2de/attachment-0001.html>