Review Request 120318: PoC: Package Manager integration for the AppsModel

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120318/#review67207
-----------------------------------------------------------


Hmm, overall approach seems fine I think :). Using the executable as search key might not always find the right package, but then using the desktop file name isn't any more reliable, and the user can use muon-discover to check the result anyway.

There's a laundry list of minor things to do:

- Separate files for PackageKitJob
- Coding style fixes
- Action needs "..." and should probably use the muon icon

I'm happy to do all that stuff though. More important is making it build-time optional :). You have way more CMake fu than I do, mind doing that?

- Eike Hein


On Sept. 22, 2014, 2:54 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120318/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 2:54 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future.
> 
> It adds an entry on the menu that is called "Remove '<packagename>'" that opens a software center. I set it to muon-discover for now, but this should be iterated over.
> 
> To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7b794ff 
>   applets/kicker/CMakeLists.txt 0688732 
>   applets/kicker/plugin/appsmodel.cpp b88d711 
> 
> Diff: https://git.reviewboard.kde.org/r/120318/diff/
> 
> 
> Testing
> -------
> 
> I uninstalled openarena, selfcompiled software cannot removed.
> 
> The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140922/8e71a4ec/attachment.html>