Review Request 120316: standalone application mode for plasmashell
Marco Martin
notmart at gmail.com
Mon Sep 22 14:11:23 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120316/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This is as alternative to https://git.reviewboard.kde.org/r/120270/
with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated.
It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday).
One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated)
Diffs
-----
shell/desktopview.h 6aeeeb6
shell/desktopview.cpp 08c1c32
shell/main.cpp e737007
shell/shellcorona.cpp eeb01af
shell/shellmanager.h eef25aa
shell/shellmanager.cpp f6472cb
Diff: https://git.reviewboard.kde.org/r/120316/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140922/dab974c3/attachment.html>
More information about the Plasma-devel
mailing list