Review Request 120314: Add timezones support into clock applet

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120314/#review67181
-----------------------------------------------------------


Thanks for your work! :)


applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120314/#comment46877>

    I think this should be i18n'd
    
    just time
     -> return time
    time + timezone
     -> return i18nc("explain", "%1 (%2)", time, timezone)
    time + date 
     -> return time + "<br>" + date
    time + timezone + date
     -> return time + "<br>" + i18nc("explain", "%1 (%2)", date, timezone)



applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120314/#comment46876>

    delta > 0



applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120314/#comment46878>

    Remove



applets/digital-clock/package/contents/ui/configTimeZones.qml
<https://git.reviewboard.kde.org/r/120314/#comment46879>

    Whitespace



applets/digital-clock/plugin/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120314/#comment46881>

    Still needed after your changes?


- Kai Uwe Broulik


On Sept. 22, 2014, 11:05 vorm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120314/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 11:05 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I've picked up Kai's branch where he started the timezone support and finished it.
> 
> New features:
>  * timezones tab in the config
>  * changing timezones by scrolling a wheel on the clock
>    * that's optional, defaults to off
>  * displaying non-local timezones as either city or abbreviation
>  * "Show time zone" config option is now changed to "Show local time zone" as foreign zones are always displayed by default
>  
> What's still missing:
>  * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login
>  * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way
>  
>  
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml cbeb02f 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e78f1f3 
>   applets/digital-clock/plugin/CMakeLists.txt 0590e6e 
>   applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION 
>   applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION 
>   applets/digital-clock/plugin/processrunnerplugin.h 2b6317b 
>   applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 
>   applets/digital-clock/plugin/qmldir 3d57bbb 
>   applets/digital-clock/plugin/timezonedata.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.h PRE-CREATION 
>   applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION 
>   dataengines/time/timesource.cpp b79fd7c 
>   applets/digital-clock/package/contents/config/config.qml f897c9a 
> 
> Diff: https://git.reviewboard.kde.org/r/120314/diff/
> 
> 
> Testing
> -------
> 
> I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change).
> 
> 
> File Attachments
> ----------------
> 
> Timezone & date displayed
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png
> Timezone without date
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140922/26b3ef7c/attachment.html>