Review Request 120279: Port to KWayland client library

Martin Gräßlin mgraesslin at kde.org
Mon Sep 22 06:29:58 UTC 2014



> On Sept. 20, 2014, 11:27 p.m., Pier Luigi Fiorini wrote:
> > Modules/base/info_wayland.cpp, line 210
> > <https://git.reviewboard.kde.org/r/120279/diff/2/?file=313412#file313412line210>
> >
> >     Why we need a new connection?
> >     QPA already has one.

there is no QPA in this case. It's for reporting information for everything available even if Qt doesn't support it. Likewise the X11 info module opens an own connection.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67091
-----------------------------------------------------------


On Sept. 19, 2014, 12:49 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120279/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 12:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> By using the KWayland library we don't need to interact with the
> low level C-library.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 
>   Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 
>   Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 
>   Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 
>   Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 
>   Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 
>   Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/120279/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140922/ed5146a5/attachment.html>


More information about the Plasma-devel mailing list