Review Request 120298: Enable lastfmimagefetchertest again,
Shantanu Tushar
shantanu at kde.org
Sun Sep 21 06:53:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120298/#review67100
-----------------------------------------------------------
libs/mediacenter/lastfmimagefetcher.cpp
<https://git.reviewboard.kde.org/r/120298/#comment46833>
In addition to this, can you qDebug the error message so that when this fails in non-test scenarios, there is something to debug.
- Shantanu Tushar
On Sept. 20, 2014, 3:04 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120298/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2014, 3:04 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> This enables lastfmimagefetchertest again with error handling
>
>
> Diffs
> -----
>
> libs/mediacenter/lastfmimagefetcher.h 25d53fd
> libs/mediacenter/lastfmimagefetcher.cpp 8d9edf4
> libs/test/lastfmimagefetchertest.h f315f7c
> libs/test/lastfmimagefetchertest.cpp e9ff4f1
>
> Diff: https://git.reviewboard.kde.org/r/120298/diff/
>
>
> Testing
> -------
>
> Checked without internet, test is getting skipped.
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140921/b3445021/attachment.html>
More information about the Plasma-devel
mailing list