Review Request 120276: Initial port to frameworks for the comic dataengine.

[Andrei Amuraritei]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/
-----------------------------------------------------------

(Updated Sept. 19, 2014, 10:17 p.m.)


Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler.


Changes
-------

Fixed issues specified.


Repository: kdeplasma-addons


Description
-------

comic DataEngine initial port to frameworks.


Diffs (updated)
-----

  dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 
  dataengines/comic/comic_package.cpp 6d2ff0b 
  dataengines/comic/comicprovider.h 630ee8d 
  dataengines/comic/comicprovider.cpp ab248a5 
  dataengines/comic/comicproviderkross.h 46a9072 
  dataengines/comic/comicproviderkross.cpp 9820f05 
  dataengines/comic/comicproviderwrapper.h 81eee68 
  dataengines/comic/comicproviderwrapper.cpp 48ced42 
  dataengines/comic/plasma-dataengine-comic.desktop f9e5433 
  dataengines/comic/CMakeLists.txt 8e382e6 
  dataengines/comic/cachedprovider.cpp caca25e 
  dataengines/comic/comic.h 8cc3969 
  dataengines/comic/comic.cpp 7130f44 
  dataengines/comic/comic_package.h 32be381 

Diff: https://git.reviewboard.kde.org/r/120276/diff/


Testing
-------

Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages.
This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts.
Thanks notmart, d_ed, sebas, bshas etc for helping.


File Attachments
----------------

Rev2 of port
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/7b2d617f-1348-4b5c-ac9c-a4340436a47d__0002-Review-port-of-comic-dataengine.patch


Thanks,

Andrei Amuraritei

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140919/bb06005f/attachment.html>