Review Request 120284: sanity checking in desktops/activities scripting
Aaron J. Seigo
aseigo at kde.org
Fri Sep 19 14:04:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/
-----------------------------------------------------------
(Updated Sept. 19, 2014, 2:04 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This patch set
* checks that there are desktops for a given activity; happens when activities exist and a new shell config is being made
* checks that an activity actually exists before handing out containments for it
* allow fetching the current activity
Diffs
-----
shell/scripting/scriptengine.h 2ea0e3170e2388780ea36eefdf58caf64afbb0cb
shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf
shell/shellcorona.h 84919ff4ca22b9e481aa5719e28a664da0f2f9d1
shell/desktopview.cpp 2df96b94bb924251bb7023149cc11cb1bc7dba8e
Diff: https://git.reviewboard.kde.org/r/120284/diff/
Testing
-------
Ran plasmashell and a layout.js that was failing due to the above issues.
Thanks,
Aaron J. Seigo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140919/9b96ba09/attachment-0001.html>
More information about the Plasma-devel
mailing list