Review Request 120057: Fix scrollbar appearing on FolderView
Christoph Feck
christoph at maxiom.de
Thu Sep 18 22:26:20 UTC 2014
> On Sept. 7, 2014, 8:03 a.m., David Edmundson wrote:
> > Ship It!
Mark, do you have commit rights?
David, is the code present in Plasma 5, i.e. is a forward-port needed?
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120057/#review65946
-----------------------------------------------------------
On Sept. 5, 2014, 11:25 a.m., Mark Harmstone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120057/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 11:25 a.m.)
>
>
> Review request for Plasma and Ignat Semenov.
>
>
> Bugs: 294795
> http://bugs.kde.org/show_bug.cgi?id=294795
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Fixes bug 294795. See there for further details.
>
>
> Diffs
> -----
>
> plasma/applets/folderview/folderview.cpp f56cab1fee8848c551d3687dbd480ed1ed5ac591
>
> Diff: https://git.reviewboard.kde.org/r/120057/diff/
>
>
> Testing
> -------
>
> The patch fixes a race condition, meaning it is difficult to reproduce. However, with the patch applied I have not been able to reproduce it after dozens of reboots on a handful of different machines. Plus the scrollbar issue was always accompanied by the toolbox changing position, which still happens sporadically - strongly implying that the scrollbar is fixed.
>
>
> Thanks,
>
> Mark Harmstone
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140918/a189a072/attachment.html>
More information about the Plasma-devel
mailing list