Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo
Hugo Pereira Da Costa
hugo.pereira at free.fr
Tue Sep 16 16:17:19 UTC 2014
> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote:
> > ok, ship it, then :)
> > in the meanwhile I'll try compile a more recent Qt5 version (which branch do you use ? stable ?)
> > and then I'll go debug breeze and oxygen (I'm actually eager to)
>
> David Edmundson wrote:
> "stable" shouldn't be used.
> The right branch name is "5.4".
>
> I think the biggest issues aren't the fault of the style. Fusion is just as bad (if anything worse)
mmm. That is what I am using (5.4 branch)
but I have not pulled it for quite some time though.
Ok. Will give it a shot. Thx
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120234/#review66683
-----------------------------------------------------------
On Sept. 16, 2014, 2:33 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120234/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2014, 2:33 p.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Repository: oxygen
>
>
> Description
> -------
>
> This is the flag that application developers need to set if they want to
> support smooth scaling.
>
> From a QStyle perspective we need to support both having this set and
> not set. The demo seems a good place to start testing and fixing.
>
> With QT_DEVICE_PIXEL_RATIO=2:
> Without this flag everything looks blocky but is in the right place.
>
> With this flag, everything looks super smooth but some layout parts are
> screwed.
>
>
> Diffs
> -----
>
> kstyle/demo/main.cpp ed2f3b4
>
> Diff: https://git.reviewboard.kde.org/r/120234/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140916/d588d68a/attachment.html>
More information about the Plasma-devel
mailing list