Review Request 120232: Improve the notifications history delegates

[Martin Klapetek]

> On Sept. 16, 2014, 3:36 p.m., Kai Uwe Broulik wrote:
> > applets/notifications/package/contents/ui/NotificationDelegate.qml, line 150
> > <https://git.reviewboard.kde.org/r/120232/diff/1/?file=312516#file312516line150>
> >
> >     The label wraps, right? That would probably overlap the action buttons, if any.

No, the Heading should not wrap, we want it elided.


> On Sept. 16, 2014, 3:36 p.m., Kai Uwe Broulik wrote:
> > applets/notifications/package/contents/ui/NotificationDelegate.qml, line 151
> > <https://git.reviewboard.kde.org/r/120232/diff/1/?file=312516#file312516line151>
> >
> >     Can/Why should there be links in the title?

Apparently there can... *shrug*


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120232/#review66667
-----------------------------------------------------------


On Sept. 16, 2014, 3:18 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120232/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 3:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Basically this copies the style of the floating popup into the notification history popup. See screenshot.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml 6c447de 
> 
> Diff: https://git.reviewboard.kde.org/r/120232/diff/
> 
> 
> Testing
> -------
> 
> Tested with all variety of notifications with and without actions. All looks good.
> 
> 
> File Attachments
> ----------------
> 
> screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/16/8d9b07f9-03a6-44f7-86d9-cbaab411c116__plasma-notifications_new2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140916/e2d5be10/attachment.html>