Review Request 120232: Improve the notifications history delegates

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120232/#review66665
-----------------------------------------------------------


Oh and I forgot - there are close buttons in every notification, but they are flat and somehow icons in ToolButton stopped working for me, so that's why you cannot see them, there's at least the one blue outline which shows where the button is. 

Going to investigate why I have no icons...

- Martin Klapetek


On Sept. 16, 2014, 3:18 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120232/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 3:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Basically this copies the style of the floating popup into the notification history popup. See screenshot.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml 6c447de 
> 
> Diff: https://git.reviewboard.kde.org/r/120232/diff/
> 
> 
> Testing
> -------
> 
> Tested with all variety of notifications with and without actions. All looks good.
> 
> 
> File Attachments
> ----------------
> 
> screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/16/8d9b07f9-03a6-44f7-86d9-cbaab411c116__plasma-notifications_new2.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140916/4930a51b/attachment.html>