Review Request 120151: Cleanups in Host::categories (applets/systemtray)
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Mon Sep 15 09:42:15 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120151/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 11:42 a.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Use a QSet with O(1) lookup instead of a QList with O(n) lookup to
store and get the already added categories.
Use a switch instead of an if statement.
Diffs
-----
applets/systemtray/plugin/host.cpp f501ded
Diff: https://git.reviewboard.kde.org/r/120151/diff/
Testing
-------
Still compiles
Thanks,
Emmanuel Pescosta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140915/574d5a79/attachment.html>
More information about the Plasma-devel
mailing list