Review Request 120170: Use base color for applet configuration sidebar to match widget apps

[Kai Uwe Broulik]

> On Sept. 15, 2014, 7:58 vorm., Marco Martin wrote:
> > looks good.
> > but how does it look on Oxygen? (rounded borders of its frames may give a problem here)

I tried it on oxygen and looked fine. I didn't see it bleeding outside. But I will check again.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120170/#review66516
-----------------------------------------------------------


On Sept. 12, 2014, 7:14 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120170/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 7:14 nachm.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This uses the base color (it's white here, I have no experience with syspal) for the sidebar to match the look of the KConfig thingie used in widget-based applications.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml 37cec5a 
> 
> Diff: https://git.reviewboard.kde.org/r/120170/diff/
> 
> 
> Testing
> -------
> 
> Sidebar is white now in Breeze and dark gray on Obsidian Coast.
> 
> 
> File Attachments
> ----------------
> 
> Screen shot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/70a948e4-9042-467b-8984-5346a2a027fa__whitesidebar.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140915/a0a382f8/attachment-0001.html>