Review Request 120141: Cleanup Applet Configuration sidebar

[Eike Hein]

> On Sept. 11, 2014, 4:36 p.m., Eike Hein wrote:
> > I'm sorry to reopen, but my clock config dialog now looks like this:
> > 
> > ![Screenshot](http://wstaw.org/m/2014/09/11/clock.png)
> > 
> > What gives? :)
> 
> Eike Hein wrote:
>     Hmm I also don't really like how different from KConfigDialog this still is ... color scheme, animations, selection delegate, page switch animation, etc, it's all very inconsistent.
> 
> Kai Uwe Broulik wrote:
>     Weird. The width is based on gridUnit for quite some time now. I didn't "deliberately" break that - does it work without this patch? 
>     
>     We could make the background white but the subtle animation and stuff should stay. There's no QtQuick version of that item yet.
> 
> Kai Uwe Broulik wrote:
>     ![Dialog with white sidebar](http://wstaw.org/m/2014/09/11/whitesidebar_png_750x750_q85.jpg)
>     That also actually looks pretty decent.
> 
> Hrvoje Senjan wrote:
>     here seems to be as with Eike, even leds to usability problem, not just cometics:
>     http://i.imgur.com/AO1Om1o.png
> 
> Kai Uwe Broulik wrote:
>     Strange. Can you test whether adding back the implicitWidth: width I removed resolve that?

Yeah, adding it back fixes it.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120141/#review66282
-----------------------------------------------------------


On Sept. 11, 2014, 12:56 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120141/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 12:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This patch cleans up the Applet Configuration sidebar.
> 
> - Get rid of lagging-behind highlight
> - Provide hover feedback
> - Get rid of radius (Breeze is blocky, and it was hardcoded anyway)
> - Fix some brokenness (Column in Item in Flickable in ScrollView) and some anchoring + width set
> 
> Did not add the white background we have in the Widgets variant as imho that would break Plasma's sexyness.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml 87f40ce 
>   desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c 
> 
> Diff: https://git.reviewboard.kde.org/r/120141/diff/
> 
> 
> Testing
> -------
> 
> Works as it did before - just more beautiful :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140912/7f75f9ac/attachment.html>