Review Request 119916: Make the notification popup higher when 3 actions are present

[David Edmundson]

> On Sept. 11, 2014, 11:45 a.m., David Edmundson wrote:
> > Kai, Martin. What's the status of this?
> > Might be good to work it out whilst you're both here.
> 
> Martin Klapetek wrote:
>     It's ready, waiting for Ship it.

Ship it!


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119916/#review66227
-----------------------------------------------------------


On Sept. 3, 2014, 4:16 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119916/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 4:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Since the port of the Button component to QQC Button, the button height cannot be set anymore, therefore the height of the popup now needs to be higher when there are three actions.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml abd3ca3 
>   applets/notifications/plugin/notificationshelper.cpp 53754c5 
> 
> Diff: https://git.reviewboard.kde.org/r/119916/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/03/7ef79287-6dbb-4e49-ac44-c5e0a509821c__plasma-notifications_new1.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140911/08f31318/attachment-0001.html>