Review Request 120141: Cleanup Applet Configuration sidebar
Marco Martin
notmart at gmail.com
Thu Sep 11 11:47:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120141/#review66228
-----------------------------------------------------------
Should be good, tough is better to put screenshot in the review request if the patch is about visual changes
desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
<https://git.reviewboard.kde.org/r/120141/#comment46203>
this may pose a performance problem, don't bind things to properties that have an animation, also when opacity=0 visible is considered false, so you can just remove the line
- Marco Martin
On Sept. 11, 2014, 10:28 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120141/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 10:28 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This patch cleans up the Applet Configuration sidebar.
>
> - Get rid of lagging-behind highlight
> - Provide hover feedback
> - Get rid of radius (Breeze is blocky, and it was hardcoded anyway)
> - Fix some brokenness (Column in Item in Flickable in ScrollView) and some anchoring + width set
>
> Did not add the white background we have in the Widgets variant as imho that would break Plasma's sexyness.
>
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/AppletConfiguration.qml 87f40ce
> desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c
>
> Diff: https://git.reviewboard.kde.org/r/120141/diff/
>
>
> Testing
> -------
>
> Works as it did before - just more beautiful :)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140911/392ebdea/attachment-0001.html>
More information about the Plasma-devel
mailing list