Review Request 120130: to prevent a compiler error

Daniel Nicoletti dantti12 at gmail.com
Wed Sep 10 20:00:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120130/#review66193
-----------------------------------------------------------


Please use secrets.constBegin() and secrets.constEnd(), that code was very broken the way it is, I think I even had crashes with similar codes...

- Daniel Nicoletti


On Set. 10, 2014, 5:45 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120130/
> -----------------------------------------------------------
> 
> (Updated Set. 10, 2014, 5:45 p.m.)
> 
> 
> Review request for Plasma, Daniel Nicoletti, Jan Grulich, Kevin Krammer, and Lukáš Tinkl.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> with gcc 4.9.1 under ArchLinux
> to prevent the error:
> conversion from ‘QMap<QString, QString>::iterator’ to non-scalar type ‘QMap<QString, QString>::const_iterator’ requested
> 
> 
> Diffs
> -----
> 
>   kded/secretagent.cpp 3e4fe82672f0d034779b1dd4e8c433d9c4a22e27 
> 
> Diff: https://git.reviewboard.kde.org/r/120130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140910/b611bfcb/attachment.html>


More information about the Plasma-devel mailing list