Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

David Edmundson david at davidedmundson.co.uk
Sun Sep 7 13:48:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120092/#review65987
-----------------------------------------------------------

Ship it!


I've just added kdeframeworks to the review group in case they have comments.

- David Edmundson


On Sept. 7, 2014, 1:23 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120092/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 1:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Thanks to the awesome David, I discovered Q_GADGET and it allows us to expose the Duration stuff in KDeclarative without needing to turn it into a QObject
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kformat.h 7a6a418 
>   src/lib/util/kformat.cpp d62240e 
> 
> Diff: https://git.reviewboard.kde.org/r/120092/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140907/c0e69ae2/attachment-0001.html>


More information about the Plasma-devel mailing list