Review Request 120087: Expose DurationFormatOption from KLocale
Marco Martin
notmart at gmail.com
Sun Sep 7 09:39:07 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120087/#review65963
-----------------------------------------------------------
Ship it!
src/qmlcontrols/kcoreaddons/formats.h
<https://git.reviewboard.kde.org/r/120087/#comment46065>
would may be better to do DefaultDuration = KFcormat::DefaultDuration insteat, less copy around f magic numbers ;)
- Marco Martin
On Sept. 7, 2014, 8:24 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120087/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2014, 8:24 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> This patch exposes the duration format options from KLocale's formatDuration in KDeclarative.
>
> This alows to show a time in eg. hh:mm instead of the default hh:mm:ss
>
>
> Diffs
> -----
>
> src/qmlcontrols/kcoreaddons/formats.h 275f351
> src/qmlcontrols/kcoreaddons/formats.cpp c853e97
>
> Diff: https://git.reviewboard.kde.org/r/120087/diff/
>
>
> Testing
> -------
>
> Adjusted battery monitor, shows proper value.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140907/62bdde80/attachment.html>
More information about the Plasma-devel
mailing list