Review Request 120051: Introduce keyboard layout QML plugin
Martin Yrjölä
martin.yrjola at gmail.com
Wed Sep 3 18:39:23 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120051/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Makes the screenlocker's keyboard layout switcher plugin globally
accessible. This is needed for a keyboard layout switcher plasmoid
in kdeplasma-addons.
Diffs
-----
ksmserver/screenlocker/greeter/keyboardlayout.h
ksmserver/screenlocker/greeter/keyboardlayout.cpp
lookandfeel/contents/components/KeyboardLayout.qml f0198ae519ed7c7e3f3e8fa9ef637302680f4182
lookandfeel/contents/lockscreen/LockScreen.qml 82acdd6c569622cfca983156ef4b09cd9176417f
ksmserver/screenlocker/greeter/CMakeLists.txt 611a151826e8b9d5002233960192e131ba1ca93c
ksmserver/screenlocker/greeter/greeterapp.cpp 86794371c6211f3ff2f58717bc91a096a17ad7d3
components/CMakeLists.txt ac468c0ffdf75f614f5995cbd42bb8d3568e81fc
components/keyboardlayout/CMakeLists.txt PRE-CREATION
components/keyboardlayout/keyboardlayoutplugin.h PRE-CREATION
components/keyboardlayout/keyboardlayoutplugin.cpp PRE-CREATION
components/keyboardlayout/qmldir PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120051/diff/
Testing
-------
Tested that org.kde.plasma.workspace.keyboardlayout can be imported in plasmoids in kdeplasma-addons.
Confirmed that the layout switcher still works in the screen locker.
Test number 6 fails for me both with and without this commit. Is this a known issue? How should I proceed with this?
` 6/10 Test #6: ksmserver-lockWindowTest ......................***Failed 3.52 sec`
Thanks,
Martin Yrjölä
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140903/ea275d50/attachment.html>
More information about the Plasma-devel
mailing list