Review Request 120050: Wallpaper package structure fixes

[Marco Martin]

> On Set. 3, 2014, 5 p.m., Marco Martin wrote:
> > yes, the direction sounds sensible to me

(err, shipit just after you finish it, as you note, mis-checked the checkbox)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120050/#review65772
-----------------------------------------------------------


On Set. 3, 2014, 4:45 p.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120050/
> -----------------------------------------------------------
> 
> (Updated Set. 3, 2014, 4:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch set does two things:
> 
> 1. restore the ability to set the wallpaper to be used to the name of the wallpaper package
> 
> In the "old" days this was handled exclusively in setSingleImage, but the QML goes through addUrl wich did not have this feature. Now it does.
> 
> 2. Move the wallpaper package structure into a plugin so that wallpapers other than Image can use it.
> 
> It did mean sacrificing the built-in ability to find the prefered image size, which stays behind in Image. This means each plugin using Wallpaper/Images will need to figure out which image to use on their own. This is still better than not having access to the package definition at all, but I imagine other plugins will want similar functionality. A bridge to cross once reached?
> 
> I have not tested the patch set quite enough, only run it through some very basic usage. It does still find wallpapers and what not; I have not tested the UI configuration in Plasma Desktop, however. Basically looking for thumbs-up-this-is-a-desirable-direction or not before investing any more time in this.
> 
> 
> Diffs
> -----
> 
>   shell/packageplugins/wallpaper/wallpaper.cpp  
>   shell/packageplugins/wallpaperimages/wallpaperpackage.cpp PRE-CREATION 
>   wallpapers/image/CMakeLists.txt 50d1f1c8849a110a3e2c6a8d76ee96f5b8eb4fea 
>   wallpapers/image/backgroundlistmodel.h d5690e6859053c3debeac3ebf53bc0d947c0e8d8 
>   wallpapers/image/backgroundlistmodel.cpp ccb9d103ac2815c613783121d238ef5bd35c5655 
>   wallpapers/image/image.h c517c28d09e3187994db7085b5e9584f2d446b48 
>   wallpapers/image/image.cpp d672dfebcfb6849776aaf3faf4362a19182f7045 
>   wallpapers/image/wallpaperpackage.h 45e8736685ce50cb0b1c21a4ab80734f304ccde2 
>   wallpapers/image/wallpaperpackage.cpp 1ee524e34470acdec3e79238b1ba7151584ca858 
>   shell/packageplugins/CMakeLists.txt 16ea8c03fb4a4ec1ee64ca506be5021d6db09d8b 
>   shell/packageplugins/wallpaper/CMakeLists.txt  
>   shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop  
>   shell/packageplugins/wallpaper/wallpaper.h  
> 
> Diff: https://git.reviewboard.kde.org/r/120050/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140903/909fb36c/attachment.html>