Review Request 119916: Make the notification popup higher when 3 actions are present

Martin Klapetek martin.klapetek at gmail.com
Wed Sep 3 16:14:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119916/
-----------------------------------------------------------

(Updated Sept. 3, 2014, 6:14 p.m.)


Review request for Plasma.


Changes
-------

Notification popup now scales depending on the amount of buttons/actions in it.

It's also a bit wider as I made the buttons wider so it can fit more than just one word. See screenshot.


Repository: plasma-workspace


Description
-------

Since the port of the Button component to QQC Button, the button height cannot be set anymore, therefore the height of the popup now needs to be higher when there are three actions.


Diffs (updated)
-----

  applets/notifications/package/contents/ui/NotificationPopup.qml abd3ca3 
  applets/notifications/plugin/notificationshelper.cpp 53754c5 

Diff: https://git.reviewboard.kde.org/r/119916/diff/


Testing
-------


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140903/36032ad8/attachment.html>


More information about the Plasma-devel mailing list