Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

Felix Geyer debfx-kde at fobos.de
Tue Sep 2 18:49:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117499/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 6:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson, Thomas Lübking, and Wolfgang Bauer.


Bugs: 331761
    http://bugs.kde.org/show_bug.cgi?id=331761


Repository: kde-workspace


Description
-------

The user switichting dialog from the screen locker is destroyed when the cancel button is pressed.
As a result you can't open it again.

The screen locker uses a PlasmaComponents.PageStack to show the password input and user switching dialogs.
When a dialog is popped from the stack it is destroyed by PageStack.

This change fixes this by creating a new instance of userSessionsUI before it is pushed to the stack.
Additionally the switchUserEnabled property is set once when the screen locker is created as userSessionsUIInstance
doesn't always exist. 


Diffs
-----

  ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml 0d3c7d5 

Diff: https://git.reviewboard.kde.org/r/117499/diff/


Testing
-------

- Lock the screen
- Press "Switch user"
- Press "Cancel"
- With this patch the "Switch user" button is visible and functional.


Thanks,

Felix Geyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140902/b1b0bfcd/attachment-0001.html>


More information about the Plasma-devel mailing list