Review Request 120037: Implement scientific notation for the calculator

David Edmundson david at davidedmundson.co.uk
Tue Sep 2 17:46:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120037/#review65726
-----------------------------------------------------------

Ship it!


The while loop is a bit bodgy, but I can't find anything better. 
Good stuff!

- David Edmundson


On Sept. 2, 2014, 5:18 p.m., Martin Yrjölä wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120037/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 5:18 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Also solves the problem with the result not fitting in the display
> 
> 
> Diffs
> -----
> 
>   applets/calculator/package/contents/ui/calculator.qml 7cb16486513cf5813612dddf0286ae7af7d48a7d 
> 
> Diff: https://git.reviewboard.kde.org/r/120037/diff/
> 
> 
> Testing
> -------
> 
> Works well, except it doesn't automatically fit the text when resizing the plasmoid.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/02/56a989ba-7d45-48d5-b3ab-75ca019a42dc__2014-09-02-201114_198x418_scrot.png
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140902/25302ee5/attachment-0001.html>


More information about the Plasma-devel mailing list