Review Request 120003: Allow changing month with mouse wheel

Martin Klapetek martin.klapetek at gmail.com
Tue Sep 2 09:05:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120003/#review65686
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On Aug. 30, 2014, 2:25 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120003/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch allows changing the month using the mouse wheel. I already tried that patch earlier but with the previous approach used in the month view ("Use a ton of rectangles") it was unusable. Performance is fine with the canvas now.
> 
> With Qt 5.3's high-precision touchpad scrolling, however, we get a wheelevent for the slightest finger movement which resulted in you easily ending up 5 years in the future in one movement. Hence this hack I added, which I'm not too fond of but it works rather nicely. Traditional mouse wheel works perfectly.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/MonthView.qml 2a14f28 
> 
> Diff: https://git.reviewboard.kde.org/r/120003/diff/
> 
> 
> Testing
> -------
> 
> Yup. Going back and forth between months using mouse wheel and touchpad.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140902/0ea34d90/attachment.html>


More information about the Plasma-devel mailing list