Review Request 120029: introduce the concept of package fallback
Marco Martin
notmart at gmail.com
Mon Sep 1 18:37:38 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120029/
-----------------------------------------------------------
(Updated Sept. 1, 2014, 6:37 p.m.)
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
introduces the concept of fallback for packages.
this will replace the private statically linked class LookAndFeelAccess in workspace and desktop, but be more generic so will be usable for things like the shell package as well.
The feature has an autotest as well to check it's actually working and doesn't break other stuff.
the package structures that will use this, will just set a package in their structure::initPackage()
tough for the user of Package in c++ is possible as well to set the fallback package outside the structure if custm things are neede (it's guarded that cycles don't occur in the fallback chain)
Diffs (updated)
-----
autotests/CMakeLists.txt 4e64f38
autotests/data/testfallbackpackage/contents/ui/main.qml PRE-CREATION
autotests/data/testfallbackpackage/metadata.desktop PRE-CREATION
autotests/data/testpackage/contents/ui/otherfile.qml PRE-CREATION
autotests/fallbackpackagetest.h PRE-CREATION
autotests/fallbackpackagetest.cpp PRE-CREATION
src/plasma/data/servicetypes/plasma-shell.desktop e2c83ba
src/plasma/package.h 2c686d7
src/plasma/package.cpp 6ad3321
src/plasma/private/package_p.h d902eb1
Diff: https://git.reviewboard.kde.org/r/120029/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140901/3b524888/attachment-0001.html>
More information about the Plasma-devel
mailing list