Review Request 120885: basic undo for plasmoids deletion

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 4:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Redone here, that seems a bit more understandable than gerrit.

It introduces a new status for applets, AwaitingDeletionStatus. triggering the delete action, puts the applet in AwaitingDeletionStatus. triggering it again it really deletes it. A notification with an undo action is emitted when the applet goes in AwaitingDeletionStatus.

The appelt is really deleted when either:
* A minute timeout expires
* The user manually closes the notification
* Plasma is shut down and the applet is in awaitingdeletion status

It would then be job for the qml part to actually hide applets that are AwaitingDeletionStatus as they don't exist anymore.


Diffs
-----

  src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6 
  src/plasma/private/applet_p.cpp 44ecd25 
  src/scriptengines/qml/plasmoid/appletinterface.h 728eea3 
  src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION 
  src/plasma/private/applet_p.h 76a1270 
  src/plasma/applet.h 06b2722 
  src/plasma/applet.cpp f4b5410 
  CMakeLists.txt 10c0ef4 
  src/desktoptheme/breeze-dark/CMakeLists.txt d7ad680 
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svgz 102869e 
  src/plasma/CMakeLists.txt 7cc2fe3 

Diff: https://git.reviewboard.kde.org/r/120885/diff/


Testing
-------

I'm not 100% sold on the technical approach on how is done, but it seems to work reliably


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141031/9cbf3155/attachment.html>