Review Request 120885: basic undo for plasmoids deletion

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69596
-----------------------------------------------------------


final round of minor comments.


src/plasma/private/applet_p.cpp
<https://git.reviewboard.kde.org/r/120885/#comment48749>

    if (isContainment()) 
    
    change the message to not say "widget"



src/scriptengines/qml/plasmoid/appletinterface.h
<https://git.reviewboard.kde.org/r/120885/#comment48750>

    so why not put it in containmentinterface.h?



src/scriptengines/qml/plasmoid/appletinterface.cpp
<https://git.reviewboard.kde.org/r/120885/#comment48751>

    connect(object, SIGNAL, [=]) 
    
    behaves differently from
    
    connect(object, SIGNAL, this, [=]) 
    
    in that the first won't get disconnected when 'this' is deleted.
    
    (I think, I'm still not 100% sure of some of this lambda magic)



src/scriptengines/qml/plasmoid/containmentinterface.cpp
<https://git.reviewboard.kde.org/r/120885/#comment48752>

    should we init m_positionBeforeRemoval to -1,-1 ?


- David Edmundson


On Oct. 30, 2014, 7:34 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120885/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 7:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Redone here, that seems a bit more understandable than gerrit.
> 
> It introduces a new status for applets, AwaitingDeletionStatus. triggering the delete action, puts the applet in AwaitingDeletionStatus. triggering it again it really deletes it. A notification with an undo action is emitted when the applet goes in AwaitingDeletionStatus.
> 
> The appelt is really deleted when either:
> * A minute timeout expires
> * The user manually closes the notification
> * Plasma is shut down and the applet is in awaitingdeletion status
> 
> It would then be job for the qml part to actually hide applets that are AwaitingDeletionStatus as they don't exist anymore.
> 
> 
> Diffs
> -----
> 
>   src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION 
>   src/plasma/private/applet_p.h 76a1270 
>   src/plasma/private/applet_p.cpp 44ecd25 
>   src/scriptengines/qml/plasmoid/appletinterface.h 728eea3 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6 
>   CMakeLists.txt 10c0ef4 
>   src/desktoptheme/breeze-dark/CMakeLists.txt d7ad680 
>   src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svgz 102869e 
>   src/plasma/CMakeLists.txt 7cc2fe3 
>   src/plasma/applet.h 06b2722 
>   src/plasma/applet.cpp f4b5410 
> 
> Diff: https://git.reviewboard.kde.org/r/120885/diff/
> 
> 
> Testing
> -------
> 
> I'm not 100% sold on the technical approach on how is done, but it seems to work reliably
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141031/aeb99686/attachment-0001.html>