Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 9:41 p.m.)


Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking.


Changes
-------

use an internal define instead of existing/external ones to prevent future confusion


Bugs: 337742
    https://bugs.kde.org/show_bug.cgi?id=337742


Repository: plasma-workspace


Description
-------

discussion was in https://git.reviewboard.kde.org/r/120431/
removed the version checks, as we know we have kdelibs >= 4.5 ;-)


Diffs (updated)
-----

  drkonqi/bugzillaintegration/bugzillalib.h 570169b 
  drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f 

Diff: https://git.reviewboard.kde.org/r/120876/diff/


Testing
-------

builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before.


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/e5047ad2/attachment.html>