Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

[Thomas Lübking]

> On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote:
> > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is just a bitshifting macro) - it's the important part in the original patch ;-)
> 
> Thomas Lübking wrote:
>     To prevent future confusion, one might want to add
>     
>     #define KDE_MAKE_BUGZILLA_VERSION KDE_MAKE_VERSION
>     
>     or sth. like this.
> 
> Hrvoje Senjan wrote:
>     note to self: never blindly c/p pathes ;-)
>     still, i wonder, how will those versions get evaluated if building with kdelibs > 4.5.x ?
>     i guess i should read the patch and discussion more closely.
> 
> Thomas Lübking wrote:
>     the numbers refer to bugzilla 4.5.x - "KDE_MAKE_VERSION(a,b,c)" is just "a<<16 | b<<8 | c" (no, i don't know why it wastes 8 bits ;-)
>     You'd typically test against KDE_VERSION or directly use KDE_IS_VERSION to actually compare the runtime KDE library.
>     
>     This patch however tests against numbers it queries from the bugzilla server.
> 
> Hrvoje Senjan wrote:
>     in order not to put back in dependancy to kdelibs4support, going to try with QT_VERSION_CHECK. hopefully to have same effect

Yes, has.
However, now it reads even more misleading.

Maybe put

#define MAKE_BUGZILLA_VERSION(a,b,c) (((a) << 16) | ((b) << 8) | (c))

below the includes and use that to prevent future confusion?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/#review69429
-----------------------------------------------------------


On Okt. 29, 2014, 8:25 nachm., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120876/
> -----------------------------------------------------------
> 
> (Updated Okt. 29, 2014, 8:25 nachm.)
> 
> 
> Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking.
> 
> 
> Bugs: 337742
>     https://bugs.kde.org/show_bug.cgi?id=337742
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> discussion was in https://git.reviewboard.kde.org/r/120431/
> removed the version checks, as we know we have kdelibs >= 4.5 ;-)
> 
> 
> Diffs
> -----
> 
>   drkonqi/bugzillaintegration/bugzillalib.h 570169b 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f 
> 
> Diff: https://git.reviewboard.kde.org/r/120876/diff/
> 
> 
> Testing
> -------
> 
> builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/d8311a3a/attachment.html>