Review Request 120894: Forward wheel events inside panelview

[Kai Uwe Broulik]

> On Okt. 29, 2014, 7:55 nachm., Marco Martin wrote:
> > shell/panelview.cpp, line 688
> > <https://git.reviewboard.kde.org/r/120894/diff/1/?file=323565#file323565line688>
> >
> >     would be cleaner to put it in its own case, instead of grouped together with the mouse events, since is completely separed anyways

QWheelEvent doesn't have a windowPos() which is why I put it in there. Or should I make a separate case and have a cast to QMouseEvent and QWheelEvent there?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120894/#review69482
-----------------------------------------------------------


On Okt. 29, 2014, 7:33 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120894/
> -----------------------------------------------------------
> 
> (Updated Okt. 29, 2014, 7:33 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 340412
>     https://bugs.kde.org/show_bug.cgi?id=340412
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This makes it also forward wheel events in the same fashion as it does with clicks. Restores Fitt's law for taskmanager wheeling. A similar patch for plasma-frameworks dialog is needed as well.
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 2bece00 
> 
> Diff: https://git.reviewboard.kde.org/r/120894/diff/
> 
> 
> Testing
> -------
> 
> Throw your mouse to the edge where your taskmanager is and wheel. Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/be40bbb0/attachment.html>