Review Request 120891: Remove unused logout effects in KSMServer

Marco Martin notmart at gmail.com
Wed Oct 29 17:37:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120891/#review69473
-----------------------------------------------------------

Ship it!


+1 that's in the category of "world cultural heritage code"

- Marco Martin


On Ott. 29, 2014, 5:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120891/
> -----------------------------------------------------------
> 
> (Updated Ott. 29, 2014, 5:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Remove unused logout effects in KSMServer
> 
> KWin handles logout effects, it's not complied at the moment and it
> won't ever be again.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt 083c129 
>   ksmserver/curtaineffect.h 32b1f37 
>   ksmserver/curtaineffect.cpp 52751e8 
>   ksmserver/fadeeffect.h 2bba96d 
>   ksmserver/fadeeffect.cpp 3138f65 
>   ksmserver/logouteffect.h 59c1aca 
>   ksmserver/logouteffect.cpp cafe452 
> 
> Diff: https://git.reviewboard.kde.org/r/120891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/45e7c5f9/attachment-0001.html>


More information about the Plasma-devel mailing list