Review Request 120881: [tabbox] Window Switcher layouts moved to kdeplasma-addons

[Thomas Lübking]

> On Okt. 29, 2014, 10:07 vorm., Thomas Lübking wrote:
> > i recall a crashbug on kf5 which occurred when a swtcher was configured, but none could be loaded (got to look out for the id)
> > in case the code cannot be reasonably hardened otherwise, we might need to keep a failsafe. (but in either case will have to deal with that bug first, unless already fixed)
> 
> Martin Gräßlin wrote:
>     it should work:
>         if (file.isNull()) {
>             qDebug() << "Could not find QML file for window switcher";
>             return nullptr;
>         }
>     
>     given that code I'd expect that the code would support it. But yes, we should clearly not crash if the switcher is missing. I'll verify by deleting the installed switchers.

Found it, had fixed it ;-)
https://bugs.kde.org/show_bug.cgi?id=337853


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120881/#review69398
-----------------------------------------------------------


On Okt. 29, 2014, 7:55 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120881/
> -----------------------------------------------------------
> 
> (Updated Okt. 29, 2014, 7:55 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> [tabbox] Window Switcher layouts moved to kdeplasma-addons
> 
> 
> Diffs
> -----
> 
>   tabbox/qml/CMakeLists.txt e7d3b227eabf27622254ad8e50e97e6fcbec5c51 
>   tabbox/qml/IconTabBox.qml 589d3da7e2f7eb7c27912687c833c1c239c8b1ff 
>   tabbox/qml/clients/big_icons/contents/ui/main.qml 74cef21ae0c782b432752477f3715994c73e459a 
>   tabbox/qml/clients/big_icons/metadata.desktop 1d13ad71d29b3a12161ffe023a2dbc6af69dbae8 
>   tabbox/qml/clients/compact/contents/ui/main.qml c90959d62788e07f7da49782023f5df285d50988 
>   tabbox/qml/clients/compact/metadata.desktop c96bfec03de451acdc9f4365c31bfb402851fcd4 
>   tabbox/qml/clients/informative/contents/ui/main.qml e50dee6b4438eccee44129285be9ee61833cc15a 
>   tabbox/qml/clients/informative/metadata.desktop 6c8bd55e17aa7b5b5d792d11cab27dde0686efbf 
>   tabbox/qml/clients/present_windows/contents/ui/main.qml d9cd3a0168970f59f1efafe278f8c0a763ba42db 
>   tabbox/qml/clients/present_windows/metadata.desktop 298e5e0d5b135e70d8102feeca131bba341a73ea 
>   tabbox/qml/clients/small_icons/contents/ui/main.qml ec4a4d769e01c8f37db4af01911724f61934e496 
>   tabbox/qml/clients/small_icons/metadata.desktop 01d5d74e0a1b2138ca2c3ad2c2f4483c51af40fa 
>   tabbox/qml/clients/text/contents/ui/main.qml 79f97c9559062b7bebab4311d97deb4a1c8ea17b 
>   tabbox/qml/clients/text/metadata.desktop a0752b597edf6b18b8a985bff035240cbdeca06c 
>   tabbox/qml/clients/thumbnails/contents/ui/main.qml f70b3fc634fdb04651d8b843c5c290922dcb2c02 
>   tabbox/qml/clients/thumbnails/metadata.desktop 7329bc8c47942c1841d63094286676de03ab7d6c 
> 
> Diff: https://git.reviewboard.kde.org/r/120881/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/3accdb63/attachment.html>