Review Request 120884: [tabbox] Get DesktopSwitcher from look and feel package

Thomas Lübking thomas.luebking at gmail.com
Wed Oct 29 10:02:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120884/#review69397
-----------------------------------------------------------

Ship it!


since the branches only differ by a substring which is also the same in the service lookup, it might be reasonable to only branch that string on top of action?

- Thomas Lübking


On Okt. 29, 2014, 8:55 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120884/
> -----------------------------------------------------------
> 
> (Updated Okt. 29, 2014, 8:55 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Like with WindowSwitcher the configured value might be for the
> look and feel package and thus we should first try to locate it
> from the look and feel package.
> 
> [tabbox/qml] Default desktop switcher moved to look and feel package
> 
> 
> Diffs
> -----
> 
>   tabbox/qml/CMakeLists.txt e7d3b227eabf27622254ad8e50e97e6fcbec5c51 
>   tabbox/qml/desktops/informative/contents/ui/main.qml 54179e6b3d3c222351b1efb4e9ef276dc28df880 
>   tabbox/qml/desktops/informative/metadata.desktop a1495d58bca63577e0d39d87193e5b44a3a7ee0e 
>   tabbox/tabbox.cpp aea7e11c635059850eec05045e68f661f15e7938 
>   tabbox/tabboxhandler.cpp 44bed90f87da33fc5404b3cd8099d49edafabb5c 
> 
> Diff: https://git.reviewboard.kde.org/r/120884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/2efdef2e/attachment-0001.html>


More information about the Plasma-devel mailing list