Review Request 120885: basic undo for plasmoids deletion
Marco Martin
notmart at gmail.com
Wed Oct 29 09:50:36 UTC 2014
> On Oct. 29, 2014, 9:39 a.m., Martin Klapetek wrote:
> > src/plasma/data/notifications/plasmashell.notifyrc, line 9
> > <https://git.reviewboard.kde.org/r/120885/diff/1/?file=322830#file322830line9>
> >
> > You maaaayyybe also want Sound?
hmm, really?
> On Oct. 29, 2014, 9:39 a.m., Martin Klapetek wrote:
> > src/plasma/private/applet_p.cpp, line 238
> > <https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line238>
> >
> > Can you confirm that after the timeout timeouts, the notification is removed from the notification history popup?
> >
> > Just wondering if it actually removes it on close()...
yep, the notification is going away from the history at timeout
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69385
-----------------------------------------------------------
On Oct. 29, 2014, 9:28 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120885/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 9:28 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Redone here, that seems a bit more understandable than gerrit.
>
> It introduces a new status for applets, AwaitingDeletionStatus. triggering the delete action, puts the applet in AwaitingDeletionStatus. triggering it again it really deletes it. A notification with an undo action is emitted when the applet goes in AwaitingDeletionStatus.
>
> The appelt is really deleted when either:
> * A minute timeout expires
> * The user manually closes the notification
> * Plasma is shut down and the applet is in awaitingdeletion status
>
> It would then be job for the qml part to actually hide applets that are AwaitingDeletionStatus as they don't exist anymore.
>
>
> Diffs
> -----
>
> src/plasma/plasma.h 15c346b
> src/plasma/private/applet_p.h 76a1270
> src/plasma/private/applet_p.cpp 44ecd25
> src/plasma/private/containment_p.cpp 3836772
> src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3
> src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6
> CMakeLists.txt 10c0ef4
> src/plasma/CMakeLists.txt 7cc2fe3
> src/plasma/applet.cpp f4b5410
> src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120885/diff/
>
>
> Testing
> -------
>
> I'm not 100% sold on the technical approach on how is done, but it seems to work reliably
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/b7b57234/attachment-0001.html>
More information about the Plasma-devel
mailing list