Review Request 120885: basic undo for plasmoids deletion

[Marco Martin]

> On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote:
> > src/plasma/private/applet_p.cpp, line 240
> > <https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line240>
> >
> >     The notification should have the plasmoid icon, no?

indeed. knotification doesn't have api for just icons, just possible to set a qpixmap.
what i'm concerned is that taking the icon pixmap may end up with a bad scaling if the view has a different size


> On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote:
> > src/plasma/private/applet_p.cpp, line 272
> > <https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line272>
> >
> >     Does removing notifications actually work with our current notification plasmoid?

yep


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69387
-----------------------------------------------------------


On Oct. 29, 2014, 9:28 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120885/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 9:28 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Redone here, that seems a bit more understandable than gerrit.
> 
> It introduces a new status for applets, AwaitingDeletionStatus. triggering the delete action, puts the applet in AwaitingDeletionStatus. triggering it again it really deletes it. A notification with an undo action is emitted when the applet goes in AwaitingDeletionStatus.
> 
> The appelt is really deleted when either:
> * A minute timeout expires
> * The user manually closes the notification
> * Plasma is shut down and the applet is in awaitingdeletion status
> 
> It would then be job for the qml part to actually hide applets that are AwaitingDeletionStatus as they don't exist anymore.
> 
> 
> Diffs
> -----
> 
>   src/plasma/plasma.h 15c346b 
>   src/plasma/private/applet_p.h 76a1270 
>   src/plasma/private/applet_p.cpp 44ecd25 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6 
>   CMakeLists.txt 10c0ef4 
>   src/plasma/CMakeLists.txt 7cc2fe3 
>   src/plasma/applet.cpp f4b5410 
>   src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120885/diff/
> 
> 
> Testing
> -------
> 
> I'm not 100% sold on the technical approach on how is done, but it seems to work reliably
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141029/bd69e6e5/attachment-0001.html>