Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package

Thomas Lübking thomas.luebking at gmail.com
Tue Oct 28 22:15:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120849/#review69364
-----------------------------------------------------------

Ship it!


Lol, the patch looks pretty scary compared to the actual change.


tabbox/tabboxhandler.cpp
<https://git.reviewboard.kde.org/r/120849/#comment48480>

    why not? (by different name, oc)


- Thomas Lübking


On Okt. 28, 2014, 3:53 nachm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120849/
> -----------------------------------------------------------
> 
> (Updated Okt. 28, 2014, 3:53 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> We assume the configured layout name is a look and feel package. Thus
> the Switcher is located at contents/windowswitcher/WindowSwitcher.qml
> of that package.
> 
> 
> Diffs
> -----
> 
>   tabbox/tabboxconfig.h f953102986b2d5577cc89321e7fecdea336bfc07 
>   tabbox/tabboxhandler.cpp cae64e3aec31af223a51fa4126798c736df411f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120849/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141028/907c9f40/attachment.html>


More information about the Plasma-devel mailing list