Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher

Martin Gräßlin mgraesslin at kde.org
Tue Oct 28 14:32:17 UTC 2014



> On Oct. 28, 2014, 3:23 p.m., Marco Martin wrote:
> > kcms/lookandfeel/kcm.cpp, line 218
> > <https://git.reviewboard.kde.org/r/120847/diff/1/?file=322480#file322480line218>
> >
> >     just out of curiosity:
> >     window switchers are still shipped as separate packages (as this line suggests) or are inside the l&f package?

That's how I imagined it to work:
* default switcher is part of l&f package
* kwin's internal logic on how to load isn't changed

what I'm currently trying to figure out is how to find the theme from KWin side or whether it's possible to get the l&f package to install the window switcher to the path KWin would expect. Latter would be preffered as it would mean not adjusting KWin at all.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120847/#review69289
-----------------------------------------------------------


On Oct. 28, 2014, 3 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120847/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Configuration for kwinrc and reloading KWin.
> 
> As I'm not quite sure how the mechanism works, please verify that everything needed is loaded, saved, set, whatever :-)
> 
> 
> Diffs
> -----
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 08fae140be58fc3fe105b5d8770c764f077359e5 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults d16963a33a88ada2d41d966bef64a972474064bc 
>   kcms/lookandfeel/kcm.h b6b6ec99884814037ea53ca8692ed9d19a22811b 
>   kcms/lookandfeel/kcm.cpp 3ede2e05e339fbea17c504d631ccaea90728c74b 
> 
> Diff: https://git.reviewboard.kde.org/r/120847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141028/b301257a/attachment-0001.html>


More information about the Plasma-devel mailing list