Review Request 120842: [kcm-effects] Use Loader for the Video Item

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120842/#review69253
-----------------------------------------------------------

Ship it!


Looks good!

- Martin Klapetek


On Oct. 28, 2014, 11:29 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120842/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 11:29 a.m.)
> 
> 
> Review request for kwin, Plasma and Martin Klapetek.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Currently just opening the Desktop Effects KCM loads QtMultimedia which
> in turn loads gstreamer 0.10. If one opens any other KCM in
> systemsettings and changes without applying the change, the window
> freezes when the warning dialog gets shown, because the warning message
> pulls in Phonon with maybe the Gstreamer backend which uses
> gstreamer 1.0. This is bad, bad and breaks everything.
> 
> By using a Loader the problem scope gets reduced. It still happens but
> only if one actually watches a video. Only opening the KCM doesn't
> trigger the problem any more.
> 
> 
> Diffs
> -----
> 
>   kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d 
>   kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d 
> 
> Diff: https://git.reviewboard.kde.org/r/120842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141028/ee891127/attachment.html>