Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 2:29 p.m.)


Review request for Plasma and David Edmundson.


Changes
-------

Updated with feedback. All issues fixed, hours are showing in the timer with FoldHours, but that could be a bug in KFormat or something.


Repository: kdeplasma-addons


Description
-------

Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the corner though.

This is my first port to plasma qml, so I may have used some of the non suggested/recommended components, if so let me know and I'll fix it.


Diffs (updated)
-----

  applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
  applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
  applets/fifteenPuzzle/Messages.sh PRE-CREATION 
  applets/fifteenPuzzle/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
  applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
  applets/fifteenPuzzle/images/blanksquare.svg  
  applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
  applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
  applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 513cc0084df7247a520807620361b0426623727e 
  applets/fifteenPuzzle/src/Messages.sh bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
  applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
  applets/fifteenPuzzle/src/fifteen.cpp ebdcf2c0756a17ea174c0fc5fd106e157b223063 
  applets/fifteenPuzzle/src/fifteenPuzzle.h cf7885380f0e152d51cf2dc7557444e9b425b596 
  applets/fifteenPuzzle/src/fifteenPuzzle.cpp 8a1528988f3e693d20179db4a209309b0aad87fd 
  applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui ff82f331db4cee2d66f526954be63f0f5d81d250 
  applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
  applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml 92062db546dcff67f930d4888180f4e753798c27 

Diff: https://git.reviewboard.kde.org/r/120806/diff/


Testing
-------

I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 

The icon is not working in the widget adder, not sure where to install that to for it to work.
Images not supported yet, though they are in the config, maybe should remove from config until they are supported?


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141027/b024b5ee/attachment-0001.html>