Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/#review69173
-----------------------------------------------------------



applets/fifteenPuzzle/package/contents/config/config.qml
<https://git.reviewboard.kde.org/r/120806/#comment48340>

    This guy gets everywhere.



applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml
<https://git.reviewboard.kde.org/r/120806/#comment48345>

    Seems Unused
    
    (and given this is copied from the systemloadviewer plasmoid, fix that too please :) )



applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml
<https://git.reviewboard.kde.org/r/120806/#comment48344>

    there's a format time in kdeclarative somewhere.
    
    Some languages might not use :



applets/fifteenPuzzle/package/contents/ui/Piece.qml
<https://git.reviewboard.kde.org/r/120806/#comment48343>

    if you put an unknown colour (from the theme) onto a known colour (from the user's selection) you have a very easy white on white text situation.
    
    Either take two things from a theme or two things from the user.



applets/fifteenPuzzle/package/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/120806/#comment48341>

    Don't do this, we'll end up making two puzzle objects when the user resizes. Worst they won't be the saem puzzle.
    
    Keep just the full one.
    If you don't specify a compact one it will automatically collapse into an icon. Probably better for panels (we don't want a full puzzle in a panel)


- David Edmundson


On Oct. 26, 2014, 5:48 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120806/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2014, 5:48 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Config options from previous c++ version kept though names are a bit diferent.
> Images not yet supported.
> Puzzle starts at 0 in the top left corner, maybe should start with 1 in the corner though.
> 
> This is my first port to plasma qml, so I may have used some of the non suggested/recommended components, if so let me know and I'll fix it.
> 
> 
> Diffs
> -----
> 
>   applets/fifteenPuzzle/src/Messages.sh bab24ae73049f37d9693cf062eaaa98ca1e6bab0 
>   applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b 
>   applets/fifteenPuzzle/src/fifteen.cpp ebdcf2c0756a17ea174c0fc5fd106e157b223063 
>   applets/fifteenPuzzle/src/fifteenPuzzle.h cf7885380f0e152d51cf2dc7557444e9b425b596 
>   applets/fifteenPuzzle/src/fifteenPuzzle.cpp 8a1528988f3e693d20179db4a209309b0aad87fd 
>   applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui ff82f331db4cee2d66f526954be63f0f5d81d250 
>   applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 
>   applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 
>   applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION 
>   applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION 
>   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION 
>   applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION 
>   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION 
>   applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION 
>   applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 513cc0084df7247a520807620361b0426623727e 
>   applets/fifteenPuzzle/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz  
>   applets/fifteenPuzzle/images/blanksquare.svg  
>   applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION 
>   applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 
>   applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 
>   applets/fifteenPuzzle/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120806/diff/
> 
> 
> Testing
> -------
> 
> I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. 
> 
> The icon is not working in the widget adder, not sure where to install that to for it to work.
> Images not supported yet, though they are in the config, maybe should remove from config until they are supported?
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141026/c4c97077/attachment-0001.html>